chore: migrate from nx 13 to 15.6.3 #27885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c34ff8e:
|
Asset size changes
Baseline commit: 8a4890f9c1dd5e7c1ed152d5b177fc59ea67405c (build) |
📊 Bundle size report
Unchanged fixtures
|
🕵 FluentUI-v0 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 568 | 606 | 5000 | |
| Button | mount | 291 | 303 | 5000 | |
| Field | mount | 1016 | 1023 | 5000 | |
| FluentProvider | mount | 669 | 651 | 5000 | |
| FluentProviderWithTheme | mount | 74 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 72 | 63 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 70 | 10 | |
| InfoButton | mount | 8 | 15 | 5000 | |
| MakeStyles | mount | 849 | 830 | 50000 | |
| Persona | mount | 1637 | 1568 | 5000 | |
| SpinButton | mount | 1237 | 1270 | 5000 |
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| FormMinimalPerf.default | 240 | 220 | 1.09:1 |
| ImageMinimalPerf.default | 228 | 213 | 1.07:1 |
| AvatarMinimalPerf.default | 112 | 106 | 1.06:1 |
| ButtonMinimalPerf.default | 91 | 86 | 1.06:1 |
| ButtonSlotsPerf.default | 325 | 307 | 1.06:1 |
| ListCommonPerf.default | 394 | 373 | 1.06:1 |
| ListWith60ListItems.default | 368 | 347 | 1.06:1 |
| MenuMinimalPerf.default | 532 | 504 | 1.06:1 |
| PortalMinimalPerf.default | 89 | 84 | 1.06:1 |
| TextMinimalPerf.default | 204 | 193 | 1.06:1 |
| HeaderMinimalPerf.default | 215 | 205 | 1.05:1 |
| ListNestedPerf.default | 325 | 310 | 1.05:1 |
| TableMinimalPerf.default | 239 | 228 | 1.05:1 |
| ButtonOverridesMissPerf.default | 652 | 629 | 1.04:1 |
| DividerMinimalPerf.default | 214 | 205 | 1.04:1 |
| ProviderMinimalPerf.default | 201 | 194 | 1.04:1 |
| ChatDuplicateMessagesPerf.default | 155 | 150 | 1.03:1 |
| EmbedMinimalPerf.default | 1762 | 1717 | 1.03:1 |
| ProviderMergeThemesPerf.default | 688 | 666 | 1.03:1 |
| AttachmentMinimalPerf.default | 85 | 83 | 1.02:1 |
| AttachmentSlotsPerf.default | 638 | 628 | 1.02:1 |
| ChatMinimalPerf.default | 434 | 426 | 1.02:1 |
| DialogMinimalPerf.default | 457 | 447 | 1.02:1 |
| DropdownMinimalPerf.default | 1411 | 1385 | 1.02:1 |
| LabelMinimalPerf.default | 226 | 221 | 1.02:1 |
| ReactionMinimalPerf.default | 211 | 206 | 1.02:1 |
| SkeletonMinimalPerf.default | 194 | 190 | 1.02:1 |
| SliderMinimalPerf.default | 697 | 682 | 1.02:1 |
| TableManyItemsPerf.default | 1137 | 1118 | 1.02:1 |
| TooltipMinimalPerf.default | 1254 | 1227 | 1.02:1 |
| VideoMinimalPerf.default | 434 | 426 | 1.02:1 |
| AlertMinimalPerf.default | 155 | 154 | 1.01:1 |
| AnimationMinimalPerf.default | 302 | 299 | 1.01:1 |
| FlexMinimalPerf.default | 151 | 150 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 706 | 701 | 1.01:1 |
| LayoutMinimalPerf.default | 207 | 204 | 1.01:1 |
| ListMinimalPerf.default | 312 | 308 | 1.01:1 |
| MenuButtonMinimalPerf.default | 956 | 948 | 1.01:1 |
| SplitButtonMinimalPerf.default | 2270 | 2247 | 1.01:1 |
| DatepickerMinimalPerf.default | 3641 | 3630 | 1:1 |
| HeaderSlotsPerf.default | 472 | 472 | 1:1 |
| PopupMinimalPerf.default | 347 | 347 | 1:1 |
| RadioGroupMinimalPerf.default | 266 | 265 | 1:1 |
| SegmentMinimalPerf.default | 196 | 196 | 1:1 |
| CustomToolbarPrototype.default | 1449 | 1443 | 1:1 |
| CardMinimalPerf.default | 306 | 310 | 0.99:1 |
| DropdownManyItemsPerf.default | 394 | 396 | 0.99:1 |
| GridMinimalPerf.default | 191 | 192 | 0.99:1 |
| InputMinimalPerf.default | 531 | 538 | 0.99:1 |
| RosterPerf.default | 1547 | 1568 | 0.99:1 |
| ToolbarMinimalPerf.default | 535 | 540 | 0.99:1 |
| AccordionMinimalPerf.default | 80 | 82 | 0.98:1 |
| BoxMinimalPerf.default | 189 | 193 | 0.98:1 |
| CarouselMinimalPerf.default | 255 | 260 | 0.98:1 |
| ChatWithPopoverPerf.default | 192 | 195 | 0.98:1 |
| CheckboxMinimalPerf.default | 1139 | 1157 | 0.98:1 |
| StatusMinimalPerf.default | 397 | 404 | 0.98:1 |
| IconMinimalPerf.default | 384 | 390 | 0.98:1 |
| TreeMinimalPerf.default | 466 | 477 | 0.98:1 |
| TreeWith60ListItems.default | 83 | 85 | 0.98:1 |
| TextAreaMinimalPerf.default | 284 | 296 | 0.96:1 |
| LoaderMinimalPerf.default | 192 | 203 | 0.95:1 |
| RefMinimalPerf.default | 102 | 108 | 0.94:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 634 | 619 | 5000 | |
| Breadcrumb | mount | 1656 | 1664 | 1000 | |
| Checkbox | mount | 1670 | 1646 | 5000 | |
| CheckboxBase | mount | 1474 | 1478 | 5000 | |
| ChoiceGroup | mount | 2914 | 2914 | 5000 | |
| ComboBox | mount | 644 | 652 | 1000 | |
| CommandBar | mount | 6174 | 6187 | 1000 | |
| ContextualMenu | mount | 11494 | 11771 | 1000 | |
| DefaultButton | mount | 760 | 758 | 5000 | |
| DetailsRow | mount | 2195 | 2163 | 5000 | |
| DetailsRowFast | mount | 2153 | 2173 | 5000 | |
| DetailsRowNoStyles | mount | 1983 | 2004 | 5000 | |
| Dialog | mount | 2621 | 2795 | 1000 | |
| DocumentCardTitle | mount | 221 | 225 | 1000 | |
| Dropdown | mount | 1948 | 1982 | 5000 | |
| FocusTrapZone | mount | 1094 | 1090 | 5000 | |
| FocusZone | mount | 1044 | 1022 | 5000 | |
| GroupedList | mount | 40863 | 41042 | 2 | |
| GroupedList | virtual-rerender | 19790 | 19667 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50180 | 50157 | 2 | |
| GroupedListV2 | mount | 220 | 211 | 2 | |
| GroupedListV2 | virtual-rerender | 207 | 210 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 221 | 218 | 2 | |
| IconButton | mount | 1095 | 1044 | 5000 | |
| Label | mount | 326 | 339 | 5000 | |
| Layer | mount | 2658 | 2670 | 5000 | |
| Link | mount | 379 | 387 | 5000 | |
| MenuButton | mount | 917 | 911 | 5000 | |
| MessageBar | mount | 21702 | 21422 | 5000 | |
| Nav | mount | 1906 | 1940 | 1000 | |
| OverflowSet | mount | 776 | 774 | 5000 | |
| Panel | mount | 1758 | 1760 | 1000 | |
| Persona | mount | 752 | 730 | 1000 | |
| Pivot | mount | 876 | 877 | 1000 | |
| PrimaryButton | mount | 823 | 845 | 5000 | |
| Rating | mount | 4548 | 4605 | 5000 | |
| SearchBox | mount | 894 | 908 | 5000 | |
| Shimmer | mount | 1822 | 1839 | 5000 | |
| Slider | mount | 1336 | 1366 | 5000 | |
| SpinButton | mount | 2817 | 2830 | 5000 | |
| Spinner | mount | 385 | 392 | 5000 | |
| SplitButton | mount | 1777 | 1807 | 5000 | |
| Stack | mount | 416 | 403 | 5000 | |
| StackWithIntrinsicChildren | mount | 853 | 852 | 5000 | |
| StackWithTextChildren | mount | 2648 | 2641 | 5000 | |
| SwatchColorPicker | mount | 6012 | 6005 | 5000 | |
| TagPicker | mount | 1414 | 1411 | 5000 | |
| Text | mount | 376 | 386 | 5000 | |
| TextField | mount | 937 | 896 | 5000 | |
| ThemeProvider | mount | 824 | 823 | 5000 | |
| ThemeProvider | virtual-rerender | 580 | 583 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1268 | 1276 | 5000 | |
| Toggle | mount | 608 | 624 | 5000 | |
| buttonNative | mount | 190 | 192 | 5000 |
Hotell
force-pushed
the
hotell/build/nx/migrate-to-14
branch
from
156f0d3 to
1975daa
Compare
Hotell
changed the title
Hotell
commented
May 18, 2023
Hotell
commented
May 18, 2023
Hotell
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
|
there's a lot of bundle-size changes within packages - I troubleshooted the root cause and is webpack bump. some packages got significant size increase , some get decrease. Not really sure what our recommended approach is as this bundle metric can get deltas caused by us and by bundler ( which is out of our control ). IMO this size increases in some cases shouldn't block us from bumping. Diff for react-image bundle (only actual regressions) 
|
ling1726
reviewed
May 19, 2023
ling1726
approved these changes
May 19, 2023
JustSlone
approved these changes
May 19, 2023
TristanWatanabe
approved these changes
May 19, 2023
layershifter
approved these changes
May 22, 2023
Hotell
force-pushed
the
hotell/build/nx/migrate-to-14
branch
from
b7ae526 to
34c16ea
Compare
Hotell
force-pushed
the
hotell/build/nx/migrate-to-14
branch
from
34c16ea to
afff49b
Compare
🕵 fluentuiv8 No visual regressions between this PR and main |
…ues to template files
Hotell
force-pushed
the
hotell/build/nx/migrate-to-14
branch
from
afff49b to
c34ff8e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
💡 NOTES:
yarn nx migrate --runMigrationsproject.json- this will be separate PRtools/which needed move to physical files templates ( a genericgetTemplatehelper was implemented for this use-case )packages migration:
v14,15 wanted to bump following deps, which I opted out (will be done separately/as our monorepo allows it)
v14 migrates to jest 28 as well ( we already use it so no changes needed )
scaffold migrations:
api migrations:
for generators testing helpers there is now a new
createTreeWithEmptyWorkspace()helper that doesn't useworkspace.jsonratherproject.jsonper library. nx migrated our code to usecreateTreeWithEmptyV1Workspacewhich uses old behaviour - in nx >15.6.3 this will be removed and our repo will be adjusted accordinglyRelated Issue(s)